Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When the expected result is an object, use jq to determine object equality #196

Merged
merged 1 commit into from
Nov 8, 2023
Merged

When the expected result is an object, use jq to determine object equality #196

merged 1 commit into from
Nov 8, 2023

Conversation

glennj
Copy link
Contributor

@glennj glennj commented Nov 7, 2023

@glennj
For exercises where the expected result is an object,
f1f5cb1 
compare actual and expected JSON objects for equality using jq.
@glennj glennj requested a review from IsaacG November 7, 2023 18:57
@glennj
Copy link
Contributor Author

glennj commented Nov 7, 2023 •
edited
Loading

The large jq program inside the bin/generate_tests script is terrible code, but I don't have the gumption to refactor it. Probably the whole thing needs rewriting in python.

IsaacG
IsaacG approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@IsaacG IsaacG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a wee bit painful, but if it works... 🤷

@glennj glennj merged commit ef57470 into exercism:main Nov 8, 2023
2 checks passed
@glennj glennj mentioned this pull request Nov 8, 2023
Open
@glennj glennj deleted the object-equality-assertion branch November 8, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacG IsaacG IsaacG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glennj @IsaacG